From 2c5e1065c5120667786b2e50c59c87d0c56deb5f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20Nohlg=C3=A5rd?= Date: Fri, 13 Jan 2017 08:44:42 +0100 Subject: [PATCH 1/5] cortexm_common: Fix unused parameter warnings in mpu_configure --- cpu/cortexm_common/mpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cpu/cortexm_common/mpu.c b/cpu/cortexm_common/mpu.c index 27f103177..d29effdc4 100644 --- a/cpu/cortexm_common/mpu.c +++ b/cpu/cortexm_common/mpu.c @@ -67,6 +67,9 @@ int mpu_configure(uint_fast8_t region, uintptr_t base, uint_fast32_t attr) { return 0; #else + (void)region; + (void)base; + (void)attr; return -1; #endif } From 8c82d9952b4a497594ee2fa89c7f35a923763868 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20Nohlg=C3=A5rd?= Date: Fri, 13 Jan 2017 08:56:45 +0100 Subject: [PATCH 2/5] cortexm_common: Fix -Wsign-compare warning in cortexm_init --- cpu/cortexm_common/cortexm_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpu/cortexm_common/cortexm_init.c b/cpu/cortexm_common/cortexm_init.c index 1875da98f..dccee08e7 100644 --- a/cpu/cortexm_common/cortexm_init.c +++ b/cpu/cortexm_common/cortexm_init.c @@ -46,7 +46,7 @@ void cortexm_init(void) /* set SVC interrupt to same priority as the rest */ NVIC_SetPriority(SVCall_IRQn, CPU_DEFAULT_IRQ_PRIO); /* initialize all vendor specific interrupts with the same value */ - for (int i = 0; i < CPU_IRQ_NUMOF; i++) { + for (int i = 0; i < (int)CPU_IRQ_NUMOF; i++) { NVIC_SetPriority((IRQn_Type) i, CPU_DEFAULT_IRQ_PRIO); } From 45c8bc47e86140a4f6fa65e2bee8c1131e1a1c2c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20Nohlg=C3=A5rd?= Date: Fri, 13 Jan 2017 08:57:10 +0100 Subject: [PATCH 3/5] kinetis_common: Fix -Wsign-compare in gpio.c --- cpu/kinetis_common/periph/gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpu/kinetis_common/periph/gpio.c b/cpu/kinetis_common/periph/gpio.c index ffb14995b..001ac40dd 100644 --- a/cpu/kinetis_common/periph/gpio.c +++ b/cpu/kinetis_common/periph/gpio.c @@ -145,7 +145,7 @@ static inline int get_ctx(int port, int pin) */ static int get_free_ctx(void) { - for (int i = 0; i < CTX_NUMOF; i++) { + for (unsigned int i = 0; i < CTX_NUMOF; i++) { if (isr_ctx[i].cb == NULL) { return i; } From a08a70a3fa9eb4b65ff46ccf959d893e748ffda7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20Nohlg=C3=A5rd?= Date: Fri, 13 Jan 2017 08:58:30 +0100 Subject: [PATCH 4/5] drivers/at86rf2xx: Fix -Wsign-compare warning, add missing parentheses --- drivers/at86rf2xx/at86rf2xx.c | 2 +- drivers/at86rf2xx/at86rf2xx_netdev.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/at86rf2xx/at86rf2xx.c b/drivers/at86rf2xx/at86rf2xx.c index fbd06d80d..a34e802ae 100644 --- a/drivers/at86rf2xx/at86rf2xx.c +++ b/drivers/at86rf2xx/at86rf2xx.c @@ -77,7 +77,7 @@ void at86rf2xx_reset(at86rf2xx_t *dev) cpuid_get(cpuid); #if CPUID_LEN > IEEE802154_LONG_ADDRESS_LEN - for (int i = IEEE802154_LONG_ADDRESS_LEN; i < CPUID_LEN; i++) { + for (unsigned int i = IEEE802154_LONG_ADDRESS_LEN; i < CPUID_LEN; i++) { cpuid[i & 0x07] ^= cpuid[i]; } #endif diff --git a/drivers/at86rf2xx/at86rf2xx_netdev.c b/drivers/at86rf2xx/at86rf2xx_netdev.c index 7e73624a6..180d45460 100644 --- a/drivers/at86rf2xx/at86rf2xx_netdev.c +++ b/drivers/at86rf2xx/at86rf2xx_netdev.c @@ -434,8 +434,8 @@ static int _set(netdev2_t *netdev, netopt_t opt, void *val, size_t len) } else { uint8_t chan = ((uint8_t *)val)[0]; - if (chan < AT86RF2XX_MIN_CHANNEL || - chan > AT86RF2XX_MAX_CHANNEL) { + if ((chan < AT86RF2XX_MIN_CHANNEL) || + (chan > AT86RF2XX_MAX_CHANNEL)) { res = -EINVAL; break; } From 21d0266a9a81e2704056c5f610759ef44b210bc9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joakim=20Nohlg=C3=A5rd?= Date: Fri, 13 Jan 2017 09:03:50 +0100 Subject: [PATCH 5/5] sys/auto_init/saul: Fix some -Wsign-compare warnings --- sys/auto_init/saul/auto_init_adc.c | 2 +- sys/auto_init/saul/auto_init_gpio.c | 2 +- sys/auto_init/saul/auto_init_isl29020.c | 2 +- sys/auto_init/saul/auto_init_l3g4200d.c | 2 +- sys/auto_init/saul/auto_init_lis3dh.c | 2 +- sys/auto_init/saul/auto_init_lps331ap.c | 2 +- sys/auto_init/saul/auto_init_lsm303dlhc.c | 2 +- sys/auto_init/saul/auto_init_mma8652.c | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/sys/auto_init/saul/auto_init_adc.c b/sys/auto_init/saul/auto_init_adc.c index 16b020d43..af94cff45 100644 --- a/sys/auto_init/saul/auto_init_adc.c +++ b/sys/auto_init/saul/auto_init_adc.c @@ -55,7 +55,7 @@ extern saul_driver_t adc_saul_driver; void auto_init_adc(void) { DEBUG("auto init SAUL ADC\n"); - for (int i = 0; i < SAUL_ADC_NUMOF; i++) { + for (unsigned int i = 0; i < SAUL_ADC_NUMOF; i++) { const saul_adc_params_t *p = &saul_adc_params[i]; saul_adcs[i] = p; diff --git a/sys/auto_init/saul/auto_init_gpio.c b/sys/auto_init/saul/auto_init_gpio.c index 454c1d0b8..5795a21cc 100644 --- a/sys/auto_init/saul/auto_init_gpio.c +++ b/sys/auto_init/saul/auto_init_gpio.c @@ -53,7 +53,7 @@ extern saul_driver_t gpio_saul_driver; void auto_init_gpio(void) { DEBUG("auto init gpio SAUL\n"); - for (int i = 0; i < SAUL_GPIO_NUMOF; i++) { + for (unsigned int i = 0; i < SAUL_GPIO_NUMOF; i++) { const saul_gpio_params_t *p = &saul_gpio_params[i]; DEBUG("[auto_init_saul] initializing direct GPIO\n"); diff --git a/sys/auto_init/saul/auto_init_isl29020.c b/sys/auto_init/saul/auto_init_isl29020.c index c6e049729..24323bb1f 100644 --- a/sys/auto_init/saul/auto_init_isl29020.c +++ b/sys/auto_init/saul/auto_init_isl29020.c @@ -51,7 +51,7 @@ extern saul_driver_t isl29020_saul_driver; void auto_init_isl29020(void) { - for (int i = 0; i < ISL29020_NUM; i++) { + for (unsigned int i = 0; i < ISL29020_NUM; i++) { const isl29020_params_t *p = &isl29020_params[i]; DEBUG("[auto_init_saul] initializing isl29020 light sensor\n"); diff --git a/sys/auto_init/saul/auto_init_l3g4200d.c b/sys/auto_init/saul/auto_init_l3g4200d.c index a4a9a109e..f0fe75910 100644 --- a/sys/auto_init/saul/auto_init_l3g4200d.c +++ b/sys/auto_init/saul/auto_init_l3g4200d.c @@ -51,7 +51,7 @@ extern saul_driver_t l3g4200d_saul_driver; void auto_init_l3g4200d(void) { - for (int i = 0; i < L3G4200D_NUM; i++) { + for (unsigned int i = 0; i < L3G4200D_NUM; i++) { const l3g4200d_params_t *p = &l3g4200d_params[i]; DEBUG("[auto_init_saul] initializing l3g4200d gyroscope\n"); diff --git a/sys/auto_init/saul/auto_init_lis3dh.c b/sys/auto_init/saul/auto_init_lis3dh.c index 12f5a018c..59ca663d7 100644 --- a/sys/auto_init/saul/auto_init_lis3dh.c +++ b/sys/auto_init/saul/auto_init_lis3dh.c @@ -51,7 +51,7 @@ extern saul_driver_t lis3dh_saul_driver; void auto_init_lis3dh(void) { - for (int i = 0; i < LIS3DH_NUM; i++) { + for (unsigned int i = 0; i < LIS3DH_NUM; i++) { const lis3dh_params_t *p = &lis3dh_params[i]; int res; diff --git a/sys/auto_init/saul/auto_init_lps331ap.c b/sys/auto_init/saul/auto_init_lps331ap.c index e505a9e32..80fec3044 100644 --- a/sys/auto_init/saul/auto_init_lps331ap.c +++ b/sys/auto_init/saul/auto_init_lps331ap.c @@ -51,7 +51,7 @@ extern saul_driver_t lps331ap_saul_driver; void auto_init_lps331ap(void) { - for (int i = 0; i < LPS331AP_NUM; i++) { + for (unsigned int i = 0; i < LPS331AP_NUM; i++) { const lps331ap_params_t *p = &lps331ap_params[i]; DEBUG("[auto_init_saul] initializing lps331ap pressure sensor\n"); diff --git a/sys/auto_init/saul/auto_init_lsm303dlhc.c b/sys/auto_init/saul/auto_init_lsm303dlhc.c index 3c4e71ab9..fdf9b9df2 100644 --- a/sys/auto_init/saul/auto_init_lsm303dlhc.c +++ b/sys/auto_init/saul/auto_init_lsm303dlhc.c @@ -53,7 +53,7 @@ extern saul_driver_t lsm303dlhc_saul_mag_driver; void auto_init_lsm303dlhc(void) { - for (int i = 0; i < LSM303DLHC_NUM; i++) { + for (unsigned int i = 0; i < LSM303DLHC_NUM; i++) { const lsm303dlhc_params_t *p = &lsm303dlhc_params[i]; DEBUG("[auto_init_saul] initializing lsm303dlhc acc/mag sensor\n"); diff --git a/sys/auto_init/saul/auto_init_mma8652.c b/sys/auto_init/saul/auto_init_mma8652.c index bb97c115b..5d6d2d0a8 100644 --- a/sys/auto_init/saul/auto_init_mma8652.c +++ b/sys/auto_init/saul/auto_init_mma8652.c @@ -52,7 +52,7 @@ extern saul_driver_t mma8652_saul_driver; void auto_init_mma8652(void) { - for (int i = 0; i < MMA8652_NUM; i++) { + for (unsigned int i = 0; i < MMA8652_NUM; i++) { const mma8652_params_t *p = &mma8652_params[i]; DEBUG("[auto_init_saul] initializing mma8652 acc sensor\n");