sys/crypto/twofish: Add casts to ensure bit shifts fit in the target variable

8 years ago · 5ab48c2d67
parent 1c03dc261c
commit 5ab48c2d67
1 changed files with 1 additions and 1 deletions
--- a/sys/include/crypto/twofish.h
+++ b/sys/include/crypto/twofish.h
@ -187,7 +187,7 @@ extern "C" {

 #define INPACK(n, x, m) \
   x = in[4 * (n)] ^ (in[4 * (n) + 1] << 8) \
-     ^ (in[4 * (n) + 2] << 16) ^ (in[4 * (n) + 3] << 24) ^ ctx->w[m]
+     ^ ((uint32_t)in[4 * (n) + 2] << 16) ^ ((uint32_t)in[4 * (n) + 3] << 24) ^ ctx->w[m]

 #define OUTUNPACK(n, x, m) \
   x ^= ctx->w[m]; \