From ec36be1d42929bdda210bb521731a028c0d1b173 Mon Sep 17 00:00:00 2001 From: Oleg Hahm Date: Tue, 7 Mar 2017 17:34:11 +0100 Subject: [PATCH] universal_address: fix cppcheck warning --- sys/universal_address/universal_address.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/sys/universal_address/universal_address.c b/sys/universal_address/universal_address.c index 5f7187087..b581c9d30 100644 --- a/sys/universal_address/universal_address.c +++ b/sys/universal_address/universal_address.c @@ -72,6 +72,9 @@ static mutex_t mtx_access = MUTEX_INIT; */ static universal_address_container_t *universal_address_find_entry(uint8_t *addr, size_t addr_size) { + /* cppcheck-suppress unsignedLessThanZero + * (reason: UNIVERSAL_ADDRESS_MAX_ENTRIES may be zero in which case this + * code is optimized out) */ for (size_t i = 0; i < UNIVERSAL_ADDRESS_MAX_ENTRIES; ++i) { if (universal_address_table[i].address_size == addr_size) { if (memcmp((universal_address_table[i].address), addr, addr_size) == 0) { @@ -93,9 +96,9 @@ static universal_address_container_t *universal_address_get_next_unused_entry(vo { /* cppcheck-suppress unsignedLessThanZero * (reason: UNIVERSAL_ADDRESS_MAX_ENTRIES may be zero in which case this - * code is optimized out) - */ + * code is optimized out) */ if (universal_address_table_filled < UNIVERSAL_ADDRESS_MAX_ENTRIES) { + /* cppcheck-suppress unsignedLessThanZero */ for (size_t i = 0; i < UNIVERSAL_ADDRESS_MAX_ENTRIES; ++i) { if (universal_address_table[i].use_count == 0) { return &(universal_address_table[i]); @@ -298,6 +301,9 @@ void universal_address_init(void) { mutex_lock(&mtx_access); + /* cppcheck-suppress unsignedLessThanZero + * (reason: UNIVERSAL_ADDRESS_MAX_ENTRIES may be zero in which case this + * code is optimized out) */ for (size_t i = 0; i < UNIVERSAL_ADDRESS_MAX_ENTRIES; ++i) { universal_address_table[i].use_count = 0; universal_address_table[i].address_size = 0; @@ -311,6 +317,9 @@ void universal_address_reset(void) { mutex_lock(&mtx_access); + /* cppcheck-suppress unsignedLessThanZero + * (reason: UNIVERSAL_ADDRESS_MAX_ENTRIES may be zero in which case this + * code is optimized out) */ for (size_t i = 0; i < UNIVERSAL_ADDRESS_MAX_ENTRIES; ++i) { universal_address_table[i].use_count = 0; } @@ -352,6 +361,9 @@ void universal_address_print_table(void) printf("[universal_address_print_table] universal_address_table_filled: %d\n", \ (int)universal_address_table_filled); + /* cppcheck-suppress unsignedLessThanZero + * (reason: UNIVERSAL_ADDRESS_MAX_ENTRIES may be zero in which case this + * code is optimized out) */ for (size_t i = 0; i < UNIVERSAL_ADDRESS_MAX_ENTRIES; ++i) { universal_address_print_entry(&universal_address_table[i]); }