Use 'chmod a-x' instead of 'chmod -x'

There is a subtle difference when executable bit is a part of the umask.
And at least some versions (Debian/stretch) fail if the resulting mode
would've been different if not for the umask setting.

Fixes #998.

Although, with such chmods/umasks it is likely that some package installation
will break anyway. But I'll leave it until somebody complains.

Signed-off-by: Alexey Neyman <stilor@att.net>

Makefile.am

@@ -65,10 +65,10 @@ bash-completion/ct-ng: bash-completion/ct-ng.in Makefile
 install-data-hook:
 	rm -f $(DESTDIR)$(man1dir)/$(ctng_progname).1.gz
 	gzip -9 $(DESTDIR)$(man1dir)/$(ctng_progname).1
-	chmod +x $(DESTDIR)$(pkgdatadir)/scripts/config.guess
-	chmod +x $(DESTDIR)$(pkgdatadir)/scripts/config.sub
+	chmod a+x $(DESTDIR)$(pkgdatadir)/scripts/config.guess
+	chmod a+x $(DESTDIR)$(pkgdatadir)/scripts/config.sub
 if INSTALL_BASH_COMPLETION
-	chmod -x $(DESTDIR)$(compdir)/$(ctng_progname)
+	chmod a-x $(DESTDIR)$(compdir)/$(ctng_progname)
 endif
 
 uninstall-hook:

scripts/build/binutils/binutils.sh

@@ -223,7 +223,7 @@ do_binutils_backend() {
         sed -r -e "s/@@DEFAULT_LD@@/${CT_BINUTILS_LINKER_DEFAULT}/" \
             "${CT_LIB_DIR}/scripts/build/binutils/binutils-ld.in"      \
             >"${prefix}/bin/${CT_TARGET}-ld"
-        chmod +x "${prefix}/bin/${CT_TARGET}-ld"
+        chmod a+x "${prefix}/bin/${CT_TARGET}-ld"
         cp -a "${prefix}/bin/${CT_TARGET}-ld"   \
               "${prefix}/${CT_TARGET}/bin/ld"
 

scripts/build/debug/300-gdb.sh

@@ -315,7 +315,7 @@ do_debug_gdb_build() {
         # Workaround for bad versions, where the configure
         # script for gdbserver is not executable...
         # Bah, GNU folks strike again... :-(
-        chmod +x "${gdb_src_dir}/gdb/gdbserver/configure"
+        chmod a+x "${gdb_src_dir}/gdb/gdbserver/configure"
 
         gdbserver_extra_config=("${extra_config[@]}")
 

testing/docker/archlinux/Dockerfile

@@ -1,3 +1,3 @@
-FROM hoverbear/archlinux
+FROM base/archlinux:latest
 RUN pacman -Syu --noconfirm
 RUN pacman -S --noconfirm base-devel git help2man python unzip

testing/docker/dmgr.sh

@@ -109,7 +109,7 @@ action_clean()
 
     msg "Cleaning up after ${cntr}"
     if [ -d build-${cntr} ]; then
-        chmod -R +w build-${cntr}
+        chmod -R a+w build-${cntr}
         rm -rf build-${cntr}
     fi
 }

testing/docker/gentoo-amd64/Dockerfile

@@ -1,4 +1,4 @@
 FROM gentoo/stage3-amd64-hardened
 RUN wget -O /sbin/dumb-init https://github.com/Yelp/dumb-init/releases/download/v1.2.1/dumb-init_1.2.1_amd64
-RUN chmod +x /sbin/dumb-init
+RUN chmod a+x /sbin/dumb-init
 ENTRYPOINT [ "/sbin/dumb-init", "--" ]