You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
eef8eb4033
Commit 1c199f2878f6 ("kbuild: document recursive dependency limitation
/ resolution") probably intended to show a hint along with "recursive
dependency detected!" error, but it missed to add {...} guard, and the
hint is displayed in every loop of the dep_stack traverse, annoyingly.
This error was detected by GCC's -Wmisleading-indentation when switching
to build-time generation of lexer/parser.
scripts/kconfig/symbol.c: In function ‘sym_check_print_recursive’:
scripts/kconfig/symbol.c:1150:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if (stack->sym == last_sym)
^~
scripts/kconfig/symbol.c:1153:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
fprintf(stderr, "For a resolution refer to Documentation/kbuild/kconfig-language.txt\n");
^~~~~~~
I could simply add {...} to surround the three fprintf(), but I rather
chose to move the hint after the loop to make the whole message readable.
Fixes: 1c199f2878f6 ("kbuild: document recursive dependency limitation / resolution"
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>
[upstream commit e3b03bf29d6b99fab7001fb20c33fe54928c157a]
Fixes #1000
Signed-off-by: Chris Packham <judge.packham@gmail.com>
|
5 years ago | |
|---|---|---|
| .. | ||
| lxdialog | 5 years ago | |
| .gitignore | 5 years ago | |
| Makefile.am | 5 years ago | |
| check.sh | 5 years ago | |
| conf.c | 5 years ago | |
| confdata.c | 7 years ago | |
| expr.c | 5 years ago | |
| expr.h | 5 years ago | |
| kconf_id.c | 5 years ago | |
| list.h | 5 years ago | |
| lkc.h | 5 years ago | |
| lkc_proto.h | 5 years ago | |
| mconf.c | 8 years ago | |
| menu.c | 5 years ago | |
| nconf.c | 5 years ago | |
| nconf.gui.c | 5 years ago | |
| nconf.h | 8 years ago | |
| symbol.c | 5 years ago | |
| util.c | 8 years ago | |
| zconf.l | 8 years ago | |
| zconf.y | 5 years ago | |